Fix Makefile builds #184
Fix Makefile builds #184
Conversation
This commit fixes two problems exposed by Makefile builds (-m): (1) the cmark library directory is wrong and (2) the COMMON_CMAKE_OPTIONS are not quoted when building swift (thus "Unix Makefiles" ends up as two command line arguments). Tested by building for Ninja (default), Make (-m), and XCode (-x).
|
The Makefile build isn't really a recommended way to build Swift at this point, but that's no reason to get this wrong. Thanks! |
[build-script] Fix Makefile builds.
|
Also, thanks for stating which configurations you tested, and for actually testing all three of them. :-) |
|
I figured the Makefile build wasn't used much, but I reasoned either it should be fixed or removed. The fix was simple. Maybe it can be deprecated later on down the road. Thank you for merging! |
|
Makefile build produces far better progress and output information over ninja at the moment, i use it becuase of that. It also seems to impact the machine less, ninja builds seem to consume far far more memory, my 8g machine with 2 threads set, swaps under ninja but not under cmake/makefile. |
|
@thawkins |
|
Off topic, but where do we register issues? Bugs.swift.org requires a login, but has no registration system. |
|
Click "sign up" under the login box. |
|
Ahhh, sused it, the version that is being shown to things it thinks are On Sat, Dec 5, 2015, 13:49 Joe Groff [email protected] wrote:
|
|
Please file a bug report about the, er, bug reporter. |
|
There is a bug report (SR-65) for the second problem. |
Fix an edge case for trailing comments
Update README to Reflect Recent API changes
…ocki-patch-1 Updates Sourcery hash for conformance changes
This commit fixes two problems exposed by Makefile builds
(-m): (1) the cmark library directory is wrong and (2) the
COMMON_CMAKE_OPTIONS are not quoted when building swift (thus
"Unix Makefiles" ends up as two command line arguments).
Tested by building for Ninja (default), Make (-m), and XCode (-x).